Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize project scanning on Windows #34

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Optimize project scanning on Windows #34

merged 2 commits into from
Jun 11, 2024

Commits on Jun 11, 2024

  1. Optimize project scanning on Windows 

    We were using FindFirstFileW instead of FindFirstFileExW, which provides
two optimization opportunities for folder scanning:

- Specifying FindExInfoBasic avoids computing short file names
  (cAlternativeFileName), which we never use
- Specifying FIND_FIRST_EX_LARGE_FETCH increases the internal buffer
  sizes used for reading file entries

When folder hierarchy is cached (hot), the first optimization improves
scan performance by ~10%. When folder hierarchy is read from disk (cold),
the second optimization improves scan performance by ~25%. The numbers
are measured on Windows 11 / Samsung 970 EVO / x64 on Linux kernel
source tree (65k files)
    @zeux
    zeux committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d4100ca View commit details
    Browse the repository at this point in the history

  2. Update README.md 

    We do not support Windows Vista now so just remove this line as redundant.
    @zeux
    zeux committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    eb51755 View commit details
    Browse the repository at this point in the history