Optimize project scanning on Windows #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using FindFirstFileW instead of FindFirstFileExW, which provides two optimization opportunities for folder scanning: - Specifying FindExInfoBasic avoids computing short file names (cAlternativeFileName), which we never use - Specifying FIND_FIRST_EX_LARGE_FETCH increases the internal buffer sizes used for reading file entries When folder hierarchy is cached (hot), the first optimization improves scan performance by ~10%. When folder hierarchy is read from disk (cold), the second optimization improves scan performance by ~25%. The numbers are measured on Windows 11 / Samsung 970 EVO / x64 on Linux kernel source tree (65k files)
We do not support Windows Vista now so just remove this line as redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using FindFirstFileW instead of FindFirstFileExW, which provides two optimization opportunities for folder scanning:
When folder hierarchy is cached (hot), the first optimization improves scan performance by ~10%. When folder hierarchy is read from disk (cold), the second optimization improves scan performance by ~25%. The numbers are measured on Windows 11 / Samsung 970 EVO / x64 on Linux kernel source tree (65k files).
Note: both flags are not supported on Windows XP/Vista, but they are supported on Windows 7+.