Fix close connection call browser process controller #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Nov 8, 2024
| @@ -52,12 +52,11 @@ class ProcessI extends Test.Common.Process { | |||
| } | |||
|
|
|||
| class ProcessControllerI extends Test.Common.BrowserProcessController { | |||
| constructor(clientOutput, serverOutput, useWorker, scripts) { | |||
| constructor(clientOutput, serverOutput, useWorker) { | |||
There was a problem hiding this comment.
scripts was no longer used, a left over from the 3.7 setup.
pepone
commented
Nov 8, 2024
| @@ -114,12 +113,12 @@ class ProcessControllerI extends Test.Common.BrowserProcessController { | |||
| } | |||
|
|
|||
| redirect(url, current) { | |||
| current.con.close(Ice.ConnectionClose.Gracefully); | |||
| current.con.close(); | |||
There was a problem hiding this comment.
We forget to fix this when we remove ConnectionClose enum, browser tests has been broken for a while.
Would be worth to investigate if we can run them in CI.
externl
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for JavaScript browser tests.