Skip to content

Commit

Permalink
Fix close connection call browser process controller (#3107)
Browse files Browse the repository at this point in the history
  • Loading branch information
pepone authored Nov 8, 2024
1 parent f2b887b commit 5a942d6
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions js/test/Common/ControllerI.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,11 @@ class ProcessI extends Test.Common.Process {
}

class ProcessControllerI extends Test.Common.BrowserProcessController {
constructor(clientOutput, serverOutput, useWorker, scripts) {
constructor(clientOutput, serverOutput, useWorker) {
super();
this._clientOutput = clientOutput;
this._serverOutput = serverOutput;
this._useWorker = useWorker;
this._scripts = scripts;
}

async start(testSuite, exe, args, current) {
Expand Down Expand Up @@ -114,12 +113,12 @@ class ProcessControllerI extends Test.Common.BrowserProcessController {
}

redirect(url, current) {
current.con.close(Ice.ConnectionClose.Gracefully);
current.con.close();
window.location.href = url;
}
}

export async function runController(clientOutput, serverOutput, scripts) {
export async function runController(clientOutput, serverOutput) {
class Output {
constructor(output) {
this.output = output;
Expand Down Expand Up @@ -181,7 +180,7 @@ export async function runController(clientOutput, serverOutput, scripts) {
const registry = Test.Common.ProcessControllerRegistryPrx.uncheckedCast(comm.stringToProxy(str));
const adapter = await comm.createObjectAdapter("");
const ident = new Ice.Identity("ProcessController", "Browser");
const processController = adapter.add(new ProcessControllerI(out, serverOut, worker, scripts), ident);
const processController = adapter.add(new ProcessControllerI(out, serverOut, worker), ident);
registerProcessController(adapter, registry, processController);
} catch (ex) {
out.writeLine("unexpected exception while creating controller:\n" + ex.toString());
Expand Down

0 comments on commit 5a942d6

Please sign in to comment.