soc: st: stm32: stm32wbax: STM32WBA Cube 1.4.1 FW integration #80068
Conversation
zephyrbot
requested review from
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_stm32
DNM
| uint8_t AHB5_SwitchedOff = 0; | ||
| uint32_t radio_sleep_timer_val = 0; | ||
|
|
There was a problem hiding this comment.
This is strange to have these defined here and set as extern in Cube.
I'd expect the opposite (Cube code isn't supposed to depends on Zephyr code )
There was a problem hiding this comment.
Just retrieving code form Cube FW....
asm5878
force-pushed
the
STM32WBA_1_4_1_Cube_Alignment
branch
4 times, most recently
from
b9fb0a9
to
393fdd3
Compare
| void LINKLAYER_PLAT_NotifyWFIEnter(void) | ||
| { | ||
| /* Check if Radio state will allow the AHB5 clock to be cut */ | ||
|
|
||
| /* AHB5 clock will be cut in the following cases: | ||
| * - 2.4GHz radio is not in ACTIVE mode (in SLEEP or DEEPSLEEP mode). | ||
| * - RADIOSMEN and STRADIOCLKON bits are at 0. | ||
| */ | ||
| if ((LL_PWR_GetRadioMode() != LL_PWR_RADIO_ACTIVE_MODE) || | ||
| ((__HAL_RCC_RADIO_IS_CLK_SLEEP_ENABLED() == 0) && | ||
| (LL_RCC_RADIO_IsEnabledSleepTimerClock() == 0))) { | ||
| AHB5_SwitchedOff = 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a STM32Cube function implemented using STM32Cube APIs, it should exist in STM32Cube package and matching file should be included as part of https://github.com/zephyrproject-rtos/hal_stm32/tree/main/lib/stm32wba/hci.
This should STM32Cube specific code should be maintained outside of Zephyr and forked.
Risk of including such code is that maintenance will be complex as we can't get code evolutions.
Also, it raises License questions.
Same for functions introduced in soc/st/stm32/stm32wbax/hci_if/ll_sys_if.c.
There was a problem hiding this comment.
A better separation has been done to move STM32CUBE API based code inside https://github.com/zephyrproject-rtos/hal_stm32/tree/main/lib/stm32wba/hci
Files renaming done to better isolate zephyr related functions from stm32 hal related functions Signed-off-by: Alessandro Manganaro <[email protected]>
asm5878
force-pushed
the
STM32WBA_1_4_1_Cube_Alignment
branch
from
269e26f
to
3646af7
Compare
| void LINKLAYER_PLAT_Assert(uint8_t condition) | ||
| { | ||
| __ASSERT_NO_MSG(condition); | ||
| } | ||
|
|
There was a problem hiding this comment.
This should be kept.
It allows to generate Zephyr ASSERTS
| #include <zephyr/irq.h> | ||
| #include <zephyr/kernel.h> | ||
| #include <zephyr/arch/cpu.h> | ||
| #include <zephyr/sys/util.h> | ||
| #include <zephyr/drivers/entropy.h> | ||
| #include <zephyr/logging/log.h> |
There was a problem hiding this comment.
Are you sure file will compile w/o this ?
Removed unnecessary pure HAL stm32 functions Headers cleanup Signed-off-by: Alessandro Manganaro <[email protected]>
asm5878
force-pushed
the
STM32WBA_1_4_1_Cube_Alignment
branch
from
3646af7
to
e27d3a4
Compare
STM32WBA Cube FW 1.4.1 integration
Added new functions required by STM32WBA Cube FW 1.4.1 Link Layer for WFI notification management and clock source selection