Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for CKAN + various improvements #191

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Add tests for CKAN + various improvements #191

merged 7 commits into from
Nov 14, 2023

Conversation

ludovicm67
Copy link
Member

@ludovicm67 ludovicm67 commented Oct 31, 2023

This PR does the following:

  • add tests for the CKAN Trifid plugin
  • add a blank line in the XML documents generated by the CKAN plugin
  • improve types for trifid-core: this was useful to check if we are not breaking anything and to help writing the tests
  • trifid.start now returns a promise instead of nothing, to allow users to wait the instance to be ready: this is a mechanism that was required to build better tests
  • fix the formatting of the code ; to review this PR, the best would be to go through commit by commit

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: 9ea9653

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@zazuko/trifid-plugin-ckan Patch
trifid-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ludovicm67 ludovicm67 changed the title Add tests for CKAN Add tests for CKAN + various improvements Oct 31, 2023
packages/ckan/package.json Show resolved Hide resolved
packages/ckan/package.json Show resolved Hide resolved
packages/ckan/test/ckan.test.js Show resolved Hide resolved
packages/core/middlewares/errors.js Outdated Show resolved Hide resolved
packages/ckan/test/ckan.test.js Outdated Show resolved Hide resolved
packages/core/tsconfig.json Show resolved Hide resolved
packages/core/lib/config/handler.js Outdated Show resolved Hide resolved
@ludovicm67 ludovicm67 requested a review from tpluscode November 13, 2023 08:29
@ludovicm67 ludovicm67 merged commit a5d0c08 into main Nov 14, 2023
2 checks passed
@ludovicm67 ludovicm67 deleted the ckan-tests branch November 14, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants