Merge pull request #191 from zazuko/ckan-tests

Add tests for CKAN + various improvements

.changeset/four-rabbits-invite.md

@@ -0,0 +1,7 @@
+---
+"@zazuko/trifid-plugin-ckan": patch
+---
+
+Generated XML documents have a blank line at the end.
+
+This Trifid plugin will be more robust, as we created a set of tests.

.changeset/honest-cows-sniff.md

@@ -0,0 +1,8 @@
+---
+"trifid-core": minor
+---
+
+Improve types in general.
+
+`trifid.start` now returns a `Promise<import('http').Server>` instead of `void`.
+This allows to wait for the server to be ready before doing anything else.

.changeset/smooth-beans-lay.md

@@ -0,0 +1,5 @@
+---
+"trifid-core": minor
+---
+
+The errors middleware is now returning the description of the status code in the body.

.eslintrc.json

@@ -5,6 +5,7 @@
   },
   "ignorePatterns": ["**/*.ts", "**/*.d.ts", "**/*.d.ts.map"],
   "rules": {
-    "space-before-function-paren": "off"
+    "space-before-function-paren": "off",
+    "indent": ["error", 2, { "SwitchCase": 1 }]
   }
 }

packages/ckan/package.json

@@ -5,7 +5,7 @@
   "main": "src/index.js",
   "type": "module",
   "scripts": {
-    "test": "true"
+    "test": "c8 --reporter=lcov --reporter=text mocha"
   },
   "repository": {
     "type": "git",
@@ -25,5 +25,10 @@
     "dotenv": "^16.3.1",
     "sparql-http-client": "^2.4.2",
     "xmlbuilder2": "^3.1.1"
+  },
+  "devDependencies": {
+    "c8": "^8.0.1",
+    "mocha": "^10.2.0",
+    "oxigraph": "^0.3.20"
   }
 }

packages/ckan/src/xml.js

@@ -109,7 +109,7 @@ function toXML (dataset) {
         }).filter(Boolean),
       },
     },
-  }).doc().end({ prettyPrint: true })
+  }).doc().end({ prettyPrint: true }).concat('\n')
 }
 
 function serializeTerm (pointer) {