Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ipv6 socket test where ipv6 doesn't work. #4274

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix for ipv6 socket test where ipv6 doesn't work. #4274

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
810e8f3
Fix for ipv6 socket test where ipv6 doesn't work.
jellefoks Oct 16, 2024
1a7efcd
Allow udp socket sending without address
jellefoks Oct 16, 2024
e97942c
disable RecursivePostsDoNotFloodPipe also on Starboard
jellefoks Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions net/socket/udp_socket_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,13 @@ TEST_F(UDPSocketTest, ClientGetLocalPeerAddresses) {
UDPClientSocket client(DatagramSocket::DEFAULT_BIND, nullptr,
NetLogSource());
int rv = client.Connect(remote_address);
#if defined(STARBOARD)
// Starboard currently can not return ERR_ADDRESS_UNREACHABLE and instead
// will return ERR_FAILED.
if (test.may_fail && (rv == ERR_ADDRESS_UNREACHABLE || rv == ERR_FAILED)) {
#else
if (test.may_fail && rv == ERR_ADDRESS_UNREACHABLE) {
#endif
// Connect() may return ERR_ADDRESS_UNREACHABLE for IPv6
// addresses if IPv6 is not configured.
continue;
Expand Down
Loading