Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ipv6 socket test where ipv6 doesn't work. #4274

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix for ipv6 socket test where ipv6 doesn't work. #4274

merged 3 commits into from
Oct 16, 2024

Conversation

jellefoks
Copy link
Member

Since #4270, UDP socket connections are no longer
silently ignored. Starboard can not return ERR_ADDRESS_UNREACHABLE and will instead return ERR_FAILED.

This changes UDPSocketTest.ClientGetLocalPeerAddresses to allow that return value for ipv6 connections.

b/373726636
b/205134049

@jellefoks
Fix for ipv6 socket test where ipv6 doesn't work.
810e8f3 
Since youtube#4270, UDP socket connections are no longer
silently ignored. Starboard can not return ERR_ADDRESS_UNREACHABLE and will
instead return ERR_FAILED.

This changes UDPSocketTest.ClientGetLocalPeerAddresses to allow that return
value for ipv6 connections.

b/373726636
b/205134049
kaidokert
kaidokert approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick follow-up !

@jellefoks jellefoks enabled auto-merge (squash) October 16, 2024 16:18
@jellefoks
Copy link
Member Author

jellefoks commented Oct 16, 2024 •
edited
Loading

This is not a flake. It needs a corresponding win32 change in socket_send_to.cc

[ RUN      ] DedicatedWebTransportHttp3Test.CloseTimeout
[/25512:INFO:quic_connection.cc(347)] Created QUIC connection for address: 127.0.0.1:64805 with version: RFCv1
[/25512:1016/170404.271000(UTC):FATAL:socket_send_to.cc(74)] No destination passed to UDP send.

@jellefoks jellefoks merged commit 8a9e441 into youtube:25.lts.1+ Oct 16, 2024
336 of 345 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jellefoks @kaidokert