Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick PR #3171: Correcting HasEverPlayed metric entry #3266

Merged
merged 1 commit into from
May 16, 2024
Merged

Cherry pick PR #3171: Correcting HasEverPlayed metric entry #3266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/metrics/histograms/metadata/cobalt/enums.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra
<int value="1" label="True"/>
</enum>

<enum name="BooleanHasPlayed">
<int value="0" label="Never played"/>
<int value="1" label="Played"/>
</enum>

<enum name="PipelineStatus">
<summary>
Possible status values reported by the Media Pipeline
Expand Down
5 changes: 2 additions & 3 deletions tools/metrics/histograms/metadata/cobalt/histograms.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,14 @@ Always run the pretty print utility on this file after editing:
</summary>
</histogram>

<histogram name="Cobalt.Media.HasEverPlayed" enum="PipelineStatus"
<histogram name="Cobalt.Media.HasEverPlayed" enum="BooleanHasPlayed"
expires_after="never">
<!-- expires-never: Needed for baseline Media pipeline health metric. -->

<owner>[email protected]</owner>
<owner>[email protected]</owner>
<summary>
Status of the media pipeline at the end of its lifecycle for audio-video
streams with an unknown video codec.
Whether a given WebMediaPlayer instance, after preload, started playback;
</summary>
</histogram>

Expand Down
Loading