Cherry pick PR #3171: Correcting HasEverPlayed metric entry #3266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobalt.Media.HasEverPlayed was correctly being logged as base::UmaHistogramBoolean() however, it was incorrectly using an enum for PipelineStatus. This CL adds a new enum BooleanHasPlayed and sets Cobalt.Media.HasEverPlayed to use it. ( I used a new enum rather than just the Boolean enum to follow Chromium's example: https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/media/histograms.xml;l=3891) b/337308115 (cherry picked from commit 031665c)
sideb0ard
approved these changes
May 15, 2024
auto-merge was automatically disabled
May 15, 2024 22:26
Pull Request is not mergeable
auto-merge was automatically disabled
May 15, 2024 22:26
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3171
Cobalt.Media.HasEverPlayed was correctly being logged as base::UmaHistogramBoolean()
however, it was incorrectly using an enum for PipelineStatus.
This CL adds a new enum BooleanHasPlayed and sets Cobalt.Media.HasEverPlayed to use it.
( I used a new enum rather than just the Boolean enum to follow Chromium's example:
https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/media/histograms.xml;l=3891)
b/337308115