Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upload items from queue if they are for files no longer in their set #55

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Remove upload items from queue if they are for files no longer in their set #55

merged 3 commits into from
Nov 24, 2023

Conversation

sb10
Copy link
Contributor

@sb10 sb10 commented Nov 24, 2023

Also improve log output with actual error messages.

This is to fix the issue we saw in the logs that we initially thought was caused by a user adding a dir to a fofn.

@sb10 sb10 requested a review from mjkw31 November 24, 2023 10:12
mjkw31
mjkw31 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sb10 sb10 merged commit f1b92b3 into develop Nov 24, 2023
4 checks passed
@sb10 sb10 deleted the fixinvalidqueue branch November 24, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkw31 mjkw31 mjkw31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sb10 @mjkw31