Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deployment target to iOS 15.0 #780

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Aug 24, 2023

What it says in the title.

Both current known consumers of the library target iOS 15 and upwards.

This, unfortunately, introduced various deprecation warnings. Fixing them is out of scope at the moment, given the possibility that soon some of the affected classes will be removed as part of a UX refresh.

Screenshot 2023-08-24 at 1 24 42 pm
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

Both current known consumers of the library target iOS 15 and upwards.

This, unfortunately, introduced various deprecation warnings. Fixing
them is out of scope at the moment, given the possibility that soon some
of the affected classes will be removed as part of a UX refresh.
@crazytonyli
Copy link
Contributor

Oh no, those warnings failed CI build.

[!] WordPressAuthenticator did not pass validation, due to 16 warnings (but you can use --allow-warnings to ignore them).

@mokagio mokagio changed the title Prepare 7.0.0 beta release Bump deployment target to iOS 15.0 Aug 25, 2023
@mokagio
Copy link
Contributor Author

mokagio commented Aug 25, 2023

@crazytonyli thank you for checking!

😳 ouch... 🤔 I like how our pod validation doesn't allow warnings. So, I think it might be best to bench this PR.

As per the PR description, I don't think it's worth spending time on those warnings at the moment:

Fixing them is out of scope at the moment, given the possibility that soon some of the affected classes will be removed as part of a UX refresh.

What do you think?

@mokagio mokagio marked this pull request as draft August 29, 2023 01:16
@mokagio mokagio mentioned this pull request Aug 29, 2023
1 task
Base automatically changed from release/7.0.0 to trunk August 30, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants