Merge changes for 7.0.0 release #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The question was whether we should implement some kind of handling on our hand, but that seems unnecessary given Jetpack and WordPress haven't shown any issues without it. Besides, what could we return if not `false`? We no longer have the Google SDK available, so we cannot "handle" the URL in that way. Granted, there could be other ways to handle it consistent with our library implementation, but they don't seem necessary at this time.
The name now better represent what the type is about. Next, we'll update the type structure to make it easier to use.
The two `enum` cases had the same associate value type. By making `SocialUser` a `struct` with the properties of that type plus an additional `enum` property to distinguish between Apple and Google when simplify the code, avoiding a bunch of switches.
This results in the `SocialUser.Service` type becoming redundant.
Law of Demeter, plus this will allow further refactors down the line.
It turns out that Jetpack/WordPress iOS uses the user name and email information, so it makes sense to keep surfacing them.
See #778 (comment) Co-authored-by: Tony Li <[email protected]>
Streamline metadata after GoogleSignIn removal
|
@crazytonyli I wanted to wait for #780 to land here first, but after the #780 (comment), I think we'd be better off merging this as is. |
crazytonyli
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core changes in this PR, #777 and #778, have already been reviewed. What this does is merely updating the
CHANGELOG.mdandversionfield.As a reminder, I used a dedicated branch to work on breaking changes without "compromising"
trunk. Also noted theversionis suffixed withbeta.1. We shall ship a stable version when the time comes.CHANGELOG.mdif necessary.