-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the SMS 2FA #152
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
394970a
Bump fluxc
hichamboushaba 5e21a05
Show the SMS button when no auth types are provided
hichamboushaba c511664
Remove unused variable
hichamboushaba 94e7747
Attempt to fix build issue
hichamboushaba 495c669
Bump fluxc to trunk
hichamboushaba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add this to make the CI work, I'm not sure what caused the new failures 😕, looking at maven listing of this dependency, we can see it's not available in neither the Google nor the Maven Central repositories, this line should have been needed even before 🫤.
cc @ParaskP7 any ideas.
Anyway, this PR is urgent, and this should block the merge regardless of the cause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @hichamboushaba and thanks for the ping!
Yea, I am not 100% sure what happened there, but this seems pretty similar to this other case of such a miss (p1723103849516809/1723070238.781829-slack-C036Y8QL4). 🤔
I think that
jcenter
[link] is just deleting artifacts in general, maybe more aggressively nowadays, and we just can’t download that specific one from anywhere atm (or at least from those 2 places that we know of: [1] + [2]). It is good that we at least have there available on our ownjcenter-mirror
repo. 🍀PS: Thanks for making it work for yourselves by adding the
jcenter-mirror
configuration, just like it was done on multiple other repos of ours. 🥇