Fixes for the SMS 2FA #152
Conversation
hichamboushaba
changed the title
hichamboushaba
force-pushed
the
fix-sms-2fa
branch
2 times, most recently
from
ec97391
to
938224d
Compare
hichamboushaba
force-pushed
the
fix-sms-2fa
branch
from
9c7a057
to
c511664
Compare
| maven { | ||
| url "https://a8c-libs.s3.amazonaws.com/android/jcenter-mirror" | ||
| content { | ||
| includeVersion "com.android.volley", "volley", "1.1.1" |
There was a problem hiding this comment.
I had to add this to make the CI work, I'm not sure what caused the new failures 😕, looking at maven listing of this dependency, we can see it's not available in neither the Google nor the Maven Central repositories, this line should have been needed even before 🫤.
cc @ParaskP7 any ideas.
Anyway, this PR is urgent, and this should block the merge regardless of the cause.
There was a problem hiding this comment.
👋 @hichamboushaba and thanks for the ping!
Yea, I am not 100% sure what happened there, but this seems pretty similar to this other case of such a miss (p1723103849516809/1723070238.781829-slack-C036Y8QL4). 🤔
I think that jcenter [link] is just deleting artifacts in general, maybe more aggressively nowadays, and we just can’t download that specific one from anywhere atm (or at least from those 2 places that we know of: [1] + [2]). It is good that we at least have there available on our own jcenter-mirror repo. 🍀
PS: Thanks for making it work for yourselves by adding the jcenter-mirror configuration, just like it was done on multiple other repos of ours. 🥇
There was a problem hiding this comment.
Tested and approved from woocommerce/woocommerce-android#12319
This PR aligns with the changes of the FluxC PR.
With the change to revert to the
/tokenendpoint, we won't be getting a list of supported authentication types during the login, so this PR updates the logic of the visibility of the "Send SMS" button to account for this.Testing
Check the PR woocommerce/woocommerce-android#12319