-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move addMenuProvider
from onCreate
to onViewCreated
#142
Conversation
Just a side note regarding the WordPress and Jetpack apps flow: it only opens the
|
I didn't think you can use Google Sign in with a debug build? @thomashorta how did you test this for Jetpack? |
Yeah, that's correct, I was just trying to test the steps that I wrote but I was only able to do them to confirm the crash exists using the release beta build. I wasn't able to do them to confirm the crash was fixed. 😞 I think that, for testing purposes, I will just modify the I didn't test it yet though. |
I started testing using the original steps, then saw the new ones. We can create a local release build for WP, but not JP (because it uses Google signing). I'll give that a go next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomazFB
I have confirmed the fix has worked using the secondary set of testing instructions provided by @thomashorta . Using a locally built release version of WP I was able to (1) recreate the crash (2) verify this PR fixes the crash.
Let me know how I can assist further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started testing using the original steps, then saw the new ones. We can create a local release build for WP, but not JP (because it uses Google signing). I'll give that a go next
Good point @zwarm. I was able to locally build a WordPress Vanilla Release build and confirm this PR fixes the crash and correctly shows the SignupConfirmationFragment
when doing the Google Sign Up flow.
The code also looks good to me! Thanks @ThomazFB!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomazFB I tested the changes and on the Woo app, when trying to use an email that is not associated with a WordPress.com account, the app fails with a Toast message.
LGTM!
Thank you, @thomashorta, @zwarm, and @atorresveiga, for the reviews! As we have the WP and Woo scenarios covered with the tests, we can move forward by merging this PR. I'll proceed with the new version release. |
…e-crash Move `addMenuProvider` from `onCreate` to `onViewCreated`
Summary
Fix issue wordpress-mobile/WordPress-Android#20221 by adjusting the point where the menu provider added to the
SignupConfirmationFragment
view.How to Test
142-48e7fc1f82f011c246e23ac4b4a0c9195b3d7c21
version hash.We’ll use this email address to create your new WordPress.com account
(theSignupConfirmationFragment
), the view loads as expected.Update release notes:
RELEASE-NOTES.txt
if necessary.