Merge pull request #142 from wordpress-mobile/fix/signup-viewlifecycl…

…e-crash Move `addMenuProvider` from `onCreate` to `onViewCreated`
wordpress-mobile · Feb 21, 2024 · a9042ce · a9042ce
2 parents fd89374 + 57dd98f
commit a9042ce
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupConfirmationFragment.kt b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupConfirmationFragment.kt
@@ -78,8 +78,6 @@ class SignupConfirmationFragment : Fragment(), MenuProvider {
             mPhotoUrl = it.getString(ARG_SOCIAL_PHOTO_URL)
             mService = it.getString(ARG_SOCIAL_SERVICE)
         }
-
-        requireActivity().addMenuProvider(this, viewLifecycleOwner, Lifecycle.State.RESUMED)
     }
 
     override fun onCreateView(
@@ -118,6 +116,8 @@ class SignupConfirmationFragment : Fragment(), MenuProvider {
         if (savedInstanceState == null) {
             mAnalyticsListener.trackSocialSignupConfirmationViewed()
         }
+
+        requireActivity().addMenuProvider(this, viewLifecycleOwner, Lifecycle.State.RESUMED)
     }
 
     @Suppress("DEPRECATION", "OVERRIDE_DEPRECATION")