This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: we also need to do this with `/page/x`
dinhtungdu
added
status: needs review
type: enhancement
The issue is a request for an enhancement.
block: filter by price
Issues related to the Filter by Price block.
skip-changelog
PRs that you don't want to appear in the changelog.
labels
Oct 20, 2023
dinhtungdu
changed the title
Try: filter block as view block
Introduce filter view block
Oct 20, 2023
dinhtungdu
changed the title
Introduce filter view block
Frontend Filters: Introduce view block
Oct 20, 2023
dinhtungdu
changed the title
Frontend Filters: Introduce view block
Price Filter: Introduce view block
Oct 20, 2023
This was referenced Oct 23, 2023
Closing in favor of woocommerce/woocommerce#42178 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: filter by price
Issues related to the Filter by Price block.
skip-changelog
PRs that you don't want to appear in the changelog.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
filterData
.filterType
with a default value set to one of these strings to indicate their type:price
,attribute
,stock
, orrating
. Collection Filters block uses this attribute to build the filter data.rangeStyle
in this case.showInputFields
,inlineInput
.Fixes woocommerce/woocommerce#42178 #10813
Why
By delegating the data fetching and processing to the Collection Filters block, we
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]
label or a[skip-changelog]
label.Conditional:
[skip-changelog]
label is not present).Changelog