This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Try: Splitting the view of filter block into inner block #11139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: we also need to do this with `/page/x`
…the component for multiple display style support
dinhtungdu
force-pushed
the
try/inner-filter-block
branch
from
8ae3e47 to
1770f79
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/collection-filters/inner-blocks/price-filter-slider/edit.tsx
assets/js/blocks/collection-filters/inner-blocks/price-filter-slider/index.tsx assets/js/blocks/collection-filters/inner-blocks/price-filter/index.tsx assets/js/blocks/collection-filters/inner-blocks/price-filter/save.tsx assets/js/blocks/product-gallery/block-settings/index.tsx assets/js/blocks/product-gallery/index.tsx |
|
Size Change: +2.22 kB (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
dinhtungdu
removed
the
status: stale
|
Closing in favor of #11191 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #
Why
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog