[GUI] Indicate wallet is syncing after completing installer #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `amount` function can call `amount_with_size` rather than repeating the underlying call to `render_amount`.
|
Here's how it looks when importing a descriptor: |
The wallet's height is taken from the cache and is used to check if the wallet has been initially synced after creation. For the remote backend, the cache refresh should be done with the usual frequency while the wallet's height is 0 so that the sync completion can be detected sooner.
jp1ac4
force-pushed
the
gui-check-wallet-height
branch
from
24d2075
to
6f4eb79
Compare
|
I've made the following changes:
|
|
Note: while importing descriptor with a bitcoin core, the synced state is still empty which is normal because user has to trigger a rescan but it may be confusing as the "syncing" implies that the wallet is updating to a correct state. |
|
That's a good point, and bad UX from our import descriptor flow. I suppose the user should ask for the rescan at import time, before going to the wallet. |
|
As per what was discussed offline:
This should be a valid option since in the cases in which wallet height is 0 we don't expect any update from the first poll. |
edouardparis
added a commit
that referenced
this pull request
Oct 22, 2024
9208cd1 gui: don't treat wallets using bitcoind as syncing (Michael Mallan) f34bb1b gui: include node type in embedded daemon backend (Michael Mallan) Pull request description: This is a follow-up to #1370. If the user has imported a descriptor and is using bitcoind as a local node, then they will need to perform a rescan in order to see past transactions. Treating the wallet as syncing in this case could mislead the user that a rescan is being performed. Therefore, it's better to keep the past behaviour here to avoid further confusion. ACKs for top commit: edouardparis: ACK 9208cd1 Tree-SHA512: fabb3289f01c68309cd511854b0ea249e5fa1279c736bfc61c3140ca3352dfc24a1be46c977ed21c528a67c3d1f0e16521d94aaa0ee1c17d8f9ed4f3403547d0
edouardparis
added a commit
that referenced
this pull request
Oct 25, 2024
…pletes after opening ec7556e gui(home): indicate existing wallet is syncing (Michael Mallan) f7314aa gui(cache): include last poll timestamp (Michael Mallan) 9dd737b gui: upgrade liana dependency (Michael Mallan) Pull request description: This PR uses the changes from #1376 to complete #1373. It builds on the changes from #1370 to consider an existing wallet (that uses a local backend) to be syncing until the first poll completes after opening the GUI, where "existing wallet" means one that has positive height (since a newly created wallet has height 0). Note that for an external Liana daemon, this logic is only applied in case the last poll timestamp has already been set when starting the GUI. Otherwise, we can't be sure if this external daemon will ever set this value. ACKs for top commit: edouardparis: ACK ec7556e Tree-SHA512: a6db8e510a7d24ca554965512e289eb271dab41871bde9362a7af71b73c771431025b1be1092bab98b106fb520d8c6959d712909d1db9a21731f3a79c9f766a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #1361.
The home page considers the wallet to be syncing if its height is 0. In this case, the balance will slowly blink and a "Syncing..." text will appear just below.
The home page will check the wallet's height upon each cache refresh, and will reload the home page once the syncing has completed so that the updated balance is displayed without the user needing to do anything.
Both the blinking balance and "Syncing..." text use a new
Carouselwidget that cycles through different child widgets at a specified rate.EDIT: I've added an extra commit to address #1363 as that is also related to the wallet height and cache refresh.