[GUI] Don't treat wallets using bitcoind as syncing

[jp1ac4]

This is a follow-up to #1370.

If the user has imported a descriptor and is using bitcoind as a local node, then they will need to perform a rescan in order
to see past transactions. Treating the wallet as syncing in this case could mislead the user that a rescan is being performed. Therefore, it's better to keep the past behaviour here to avoid further confusion.

[edouardparis]

I think you can modify DaemonBackend for:

use crate::node::NodeType;

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum DaemonBackend {
    EmbeddedLianad(NodeType),
    ExternalLianad,
    RemoteBackend,
}

It may be more practical for the gui, wdyt ?

[jp1ac4]

It may be more practical for the gui, wdyt ?

That looks good, I'll change it to that.

Do you think it would make sense at some point to add "node_type" to getinfo ? In that case, we would also know for an external daemon, but it might not be worth making such a change just for this use case of opening a wallet for the first time.

[edouardparis]

Do you think it would make sense at some point to add "node_type" to getinfo ? In that case, we would also know for an external daemon, but it might not be worth making such a change just for this use case of opening a wallet for the first time.

Yes, I believe it is not worth it for now.

[jp1ac4]

I've made the suggested change except I decided to use Option<NodeType> just to be on the safe side as the config has Option<BitcoinBackend>. We could consider changing that in future, but for this current change I didn't want to risk introducing a panic.

[edouardparis]

ACK 9208cd1