Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batcher Lambda, infrastructure and build #2728

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

kenoir
Copy link
Contributor

@kenoir kenoir commented Oct 9, 2024

What does this change?

Part of #2721

Introduce lambda infrastructure for batcher service and start setup build process.

This change does not include code changes to allow the batcher to run as a Lambda other than a skeleton class and handler function.

Depends: wellcomecollection/terraform-aws-ecs-service#53

Next (in a new PR): Add queue & lambda trigger functionality

How to test

  • Can you run a containerised build as a lambda using the Runtime Interface Emulator?
  • Does the CI process correctly build, push to ECR and deploy the Lambda container?

How can we measure success?

When code changes are ready from #2721, they can be easily deployed.

Have we considered potential risks?

We should avoid disrupting the existing infra, build & deploy and create a parallel lambda implementation to mitigate risk involved with breaking the existing process.

event: JavaMap[String, String],
context: Context
): String = {
info(s"running batcher lambda, got event: $event")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@kenoir kenoir merged commit fe9410a into main Oct 15, 2024
5 checks passed
@kenoir kenoir deleted the rk/lambda-batcher-build branch October 15, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archive
Development

Successfully merging this pull request may close these issues.

3 participants