Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-architect the batcher service so that it works as a Lambda #2721

Open
3 tasks
Tracked by #5784
kenoir opened this issue Oct 2, 2024 · 3 comments
Open
3 tasks
Tracked by #5784

Re-architect the batcher service so that it works as a Lambda #2721

kenoir opened this issue Oct 2, 2024 · 3 comments

Comments

@kenoir
Copy link
Contributor

kenoir commented Oct 2, 2024

Part of wellcomecollection/platform#5784

This is the specific task of refactoring the ECS service so that it can operate as an SQS triggered Lambda.

It should be preceded by the RFC described in the linked issue, and followed by an ADR describing the change made.

@paul-butcher
Copy link
Contributor

One of the things I want us to consider is that the whole SQS-in/SNS-out business has its tentacles all through the invocation part of this application. Ideally, we should be able to invoke it not just by Lambda (which would still be SQS), but also from a CLI by passing it a list of strings (probably on STDIN), without having to run pretend AWS services.

Throughout the whole pipeline, we have big chains of Akka stream stuff that might be better, both for readability and reuse, if we crack them apart and name them, preferably restricting the interface parts (SQS/SNS or STDIO or whatever) to the very periphery.

@pollecuttn
Copy link

@kenoir can this be closed now?

@kenoir
Copy link
Contributor Author

kenoir commented Oct 21, 2024

@kenoir can this be closed now?

I think this one should include the work to actually shift the batcher code over too? Cc @agnesgaroux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

4 participants