Use ElementTagPostProcessor to handle image replacement #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnNiang
commented
Sep 18, 2024
JohnNiang
force-pushed
the
refactor/use-element-tag-processor
branch
from
7f5dfa5 to
d034f65
Compare
Signed-off-by: JohnNiang <[email protected]>
JohnNiang
force-pushed
the
refactor/use-element-tag-processor
branch
from
d034f65 to
4e61191
Compare
JohnNiang
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses ElementTagPostProcessor to handle image replacement instead of resolving whole HTML content before responding. Use this method can reduce memory consumption.
BTY, the processor was introduced in halo-dev/halo#6670. Please wait for halo-dev/halo#6670 to be merged before merging the current PR.
Fixes #17