-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ElementTagProcessor to handle element tag in plugin #6670
Provide ElementTagProcessor to handle element tag in plugin #6670
Conversation
单元测试没过需要修复一下 |
421e1f6
to
3fd3df7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6670 +/- ##
============================================
- Coverage 58.18% 58.08% -0.10%
- Complexity 3774 3935 +161
============================================
Files 651 675 +24
Lines 22125 23113 +988
Branches 1538 1578 +40
============================================
+ Hits 12873 13426 +553
- Misses 8641 9067 +426
- Partials 611 620 +9 ☔ View full report in Codecov by Sentry. |
/hold This processor cannot handle element tag in |
Signed-off-by: JohnNiang <[email protected]>
3fd3df7
to
33a3230
Compare
Quality Gate passedIssues Measures |
/unhold Now, the post-processor supports to handle element tags evaluated in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Current API has been published into Maven publication |
请问一下,ElementTagPostProcessor只能获取到文章元素标签,单页面的标签有没有新的处理方或者还是以前的
|
/ping @JohnNiang |
Hi @wenjing-xin , please refer to webp-sh/halo-plugin-webp-cloud#15. |
|
What type of PR is this?
/kind feature
/area plugin
What this PR does / why we need it:
This PR provides an interface ElementTagProcessor to make plugin handle element tag easily. e.g.:
After PR merged, plugins https://github.com/webp-sh/halo-plugin-webp-cloud and https://github.com/guqing/plugin-cloudinary can be refined with new method.
Does this PR introduce a user-facing change?