-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose model configuration options #1085
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 95.37% 95.52% +0.14%
==========================================
Files 315 318 +3
Lines 30950 31049 +99
==========================================
+ Hits 29520 29659 +139
+ Misses 1430 1390 -40 ☔ View full report in Codecov by Sentry. |
@dangunter, we put this (and the chain of 2 issues) on the Sept release board on the assumption that this will be ready in Sept. |
@MichaelPesce marking ready for review to simplify any contributions/testing. As mentioned in watertap-org/watertap-ui#90 , the main to-do here is to show how the option value(s) are used in building/solving e.g. the nanofiltration flowsheet, and documenting how to use when wrapping new models. |
@dangunter - one thought about this functionality- selecting a specific configuration option could change whether certain variables should be available for the user to touch. One way to deal with this would be to be able to specify behind the scenese which vars would be "grayed out" and inaccessible with particular config options. It'd probably make sense to test this out starting simple with just an RO unit alone. Alternatively, we could look at this from the perspective of a given flowsheet, where you might want to toggle between predetermined variations of a given flowsheet. Personally, I think the former example would be better to start with. |
@dangunter @MichaelPesce I am trying to get back up to speed with state of the UI. I am behind at this point. Is this PR still relevant, or is this one already covered by other UI-related PRs? Please let me know so we can decide whether to review or close this one. |
This PR was superseded by #1152 |
Fixes #1084
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: