Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose model configuration options in GUI #85

Closed
adam-a-a opened this issue May 26, 2023 · 1 comment
Closed

Expose model configuration options in GUI #85

adam-a-a opened this issue May 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request Priority:Normal Normal Priority Issue or PR question Further information is requested

Comments

@adam-a-a
Copy link

Based on some feedback from the NAWI Spring Meeting, one idea that came to mind was allowing for a drop-down box that lists configuration options for a particular model. For example:

The nanofiltration model that we presented on --- there is a configuration option called ConcentrationPolarizationType, and you can choose to either include the effects of concentration polarization (ConcentationPolarization.calculated) or exclude them (ConcentrationPolarization.none) in your model. Right now, things are setup so that we build a specific flowsheet with configuration options that are selected by the model developer who is exporting that flowsheet to the GUI. For example, ConcentrationPolarization.calculated was selected for our nanofiltration example and that's what is run when we build/solve in the GUI.

However, if we could specify the config option from the GUI and then have the flowsheet built based on the selected config option, that would offer some nice flexibility. Would a feature like that be reasonable to request?

@adam-a-a adam-a-a added enhancement New feature or request question Further information is requested labels May 26, 2023
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jun 1, 2023
@dangunter
Copy link
Collaborator

Working on this in watertap-org/watertap#1085 and #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:Normal Normal Priority Issue or PR question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants