Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: downgrade node engine to 18 #2173

Closed
wants to merge 1 commit into from
Closed

chore: downgrade node engine to 18 #2173

wants to merge 1 commit into from

Conversation

danisharora099
Copy link
Collaborator

Problem

Some js-waku library consumers are using nodejs-mobile that doesn't support node v20 as the engine: nodejs-mobile/nodejs-mobile#126, nodejs-mobile/nodejs-mobile#133

Solution

Downgrade it to 18 temporarily

Notes

@danisharora099 danisharora099 marked this pull request as ready for review October 9, 2024 10:04
@danisharora099 danisharora099 requested a review from a team as a code owner October 9, 2024 10:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 85.46 KB (0%) 1.8 s (0%) 803 ms (+40.1% 🔺) 2.6 s
Waku Simple Light Node 137.5 KB (0%) 2.8 s (0%) 1.3 s (+14.19% 🔺) 4 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 275 ms (-20.84% 🔽) 732 ms
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 324 ms (+1.5% 🔺) 771 ms
DNS discovery 72.9 KB (0%) 1.5 s (0%) 601 ms (+6.41% 🔺) 2.1 s
Peer Exchange discovery 74.1 KB (0%) 1.5 s (0%) 1.1 s (+29.84% 🔺) 2.5 s
Local Peer Cache Discovery 68.03 KB (0%) 1.4 s (0%) 1.3 s (+56.9% 🔺) 2.6 s
Privacy preserving protocols 75.99 KB (0%) 1.6 s (0%) 847 ms (+9.35% 🔺) 2.4 s
Waku Filter 79.75 KB (0%) 1.6 s (0%) 715 ms (-31.55% 🔽) 2.4 s
Waku LightPush 77.77 KB (0%) 1.6 s (0%) 824 ms (+10.15% 🔺) 2.4 s
History retrieval protocols 77.06 KB (0%) 1.6 s (0%) 931 ms (+31.25% 🔺) 2.5 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 411 ms (+261.96% 🔺) 559 ms

@danisharora099 danisharora099 force-pushed the chore/downgrade-node-18 branch 4 times, most recently from ff7aba8 to a50fcac Compare October 14, 2024 08:11
@danisharora099 danisharora099 mentioned this pull request Oct 14, 2024
Closed
@danisharora099 danisharora099 marked this pull request as draft October 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: downgrade nodejs to 18
1 participant
@danisharora099