Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade nodejs to 18 #2171

Closed
weboko opened this issue Oct 9, 2024 · 3 comments
Closed

chore: downgrade nodejs to 18 #2171

weboko opened this issue Oct 9, 2024 · 3 comments
Assignees

Comments

@weboko
Copy link
Collaborator

weboko commented Oct 9, 2024

Problem

Some of the consumers of the library are using NodeJS mobile which has support only for nodejs@18.

Solution

Downgrade NodeJS requirement in js-waku temporarily.
We need to revert #2110

@weboko weboko added this to Waku Oct 9, 2024
@weboko weboko moved this to Priority in Waku Oct 9, 2024
@weboko
Copy link
Collaborator Author

weboko commented Oct 9, 2024

Important for the next release #2135

@danisharora099 danisharora099 moved this from Priority to Code Review / QA in Waku Oct 9, 2024
@danisharora099 danisharora099 self-assigned this Oct 10, 2024
@danisharora099
Copy link
Collaborator

With experiments on PR #2173, downgrading to NodeJS18 will involve polyfilling some libraries with related dependencies that don't exist in Node18, which might also involve downgrading some js-waku dependencies that are not straightforward to polyfill.

The decision between polyfilling vs waiting for NodeJS mobile to upgrade to Node22 is a decision to make. Almost 40% of the upgrade on NodeJS mobile to Node22 has been achieved, and it might be better to hold off upgrading js-waku until the above PR is merged on NodeJS Mobile (ETA is end of October/2 weeks)

Assuming the library consumer in this context is @mattgle, what do you think?

cc @weboko

@weboko
Copy link
Collaborator Author

weboko commented Oct 22, 2024

Closing as we agreed with Zy0n not to proceed with that and I believe @mattgle is on the same page.

@weboko weboko closed this as completed Oct 22, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants