-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename HTTP Baseline Profile to HTTP Basic Profile #265
Conversation
96bf012
to
2bf7a55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name change is an improvement and should be also done in the diagrams, both in profile and architecture.
However this MR also contains many unrelated changes, presumably you branched from a different branch. Can you please constrain the scope of this MR to the name change only.
Please read my comment from above:
This PR depends on #260 because the name change is largely motivated by the re-structure proposed in that PR. I can rebase this PR once if and when that one lands. |
2bf7a55
to
d4f4d1c
Compare
d4f4d1c
to
7abc3d9
Compare
This has now been done so this change can be reviewed on its own.
Hopefully this can be done as a follow-up as I can't find the source code of the diagrams concerned. |
Thanks @benfrancis - I consider this ready to merge. The diagram source for the sequence diagram is at: "images/Sequence Diagram - WebHook.puml" |
Profile call on Sept 21. - Agree to merge after the merge conflict has been resolved. |
7abc3d9
to
2632471
Compare
@mlagally I would be grateful if you could land this PR ASAP so that I have an opportunity to resolve any resulting merge conflicts in my other 9 PRs before tomorrow's meeting, so the same thing doesn't happen again. Thank you. |
This is a follow-up to #260 which proposes renaming the "HTTP Baseline Profile" to the "HTTP Basic Profile".
The reason for this is that I think after the re-structure in #260 there's potential for confusion between the terms "Baseline Profile" and "Common Constraints". The term "baseline" may imply that all other HTTP profiles all have to be built on top of the HTTP Baseline profile, which is not the case since they can also be used on their own. This addresses similar historical concerns about the the term "Core Profile" (#5, #21).
Note that this PR builds on #260, so please only review the last commit 2bf7a55Preview | Diff