Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud events as message format for WebHooks #251

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Conversation

mlagally
Copy link
Contributor

@mlagally mlagally commented Aug 3, 2022

@benfrancis benfrancis self-requested a review August 10, 2022 09:43
@mlagally mlagally changed the title Remove cloud events as message format for WebHooks Remove cloud events as message format for WebHooks, update README.md (#248) Aug 31, 2022
@mlagally
Copy link
Contributor Author

I also updated the readme to reflect the recent name change, see #268

Copy link
Member

@benfrancis benfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README changes seem unrelated to the WebHooks change, should that not be a separate PR?

README.md Outdated
@@ -14,14 +14,14 @@ This specification serves two purposes:
provides a mechanism to describe a profile in an unambiguous way.
This mechanism can be used to define additional profiles.

- In addition it defines a **Core Profile** of the Thing Description
for use with selected protocols. The <a>Core Profile</a> formalizes
- In addition it defines a **Base Profile** of the Thing Description
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "Base Profile". There is an "HTTP Baseline Profile" which may be renamed to "HTTP Basic Profile" (#265), but it only uses HTTP (not "selected profiles" as written here).

@mlagally
Copy link
Contributor Author

Profile call on Aug 31.:
Agree to merge after removal of README.md changes

@mlagally mlagally merged commit 7359f63 into main Aug 31, 2022
@mlagally mlagally changed the title Remove cloud events as message format for WebHooks, update README.md (#248) Remove cloud events as message format for WebHooks Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants