Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows can't handle the : character in a filename. #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Windows can't handle the : character in a filename. #253

wants to merge 1 commit into from

Commits on Jul 8, 2019

  1. Windows can't handle the : character in a filename. 

    This renames the file and then makes a symlink to the original filename
when the specs are run. This will allow the module to be installed
without errors onto a windows machine.

The other alternatives I considered were things like mocking File.read to
magically translate invalid characters, but that seemed like more wtf
than this. Happy to consider other approaches though!

Fixes #224
    @binford2k
    binford2k committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    fd68f3c View commit details
    Browse the repository at this point in the history