Windows can't handle the : character in a filename. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the file and then makes a symlink to the original filename when the specs are run. This will allow the module to be installed without errors onto a windows machine. The other alternatives I considered were things like mocking File.read to magically translate invalid characters, but that seemed like more wtf than this. Happy to consider other approaches though! Fixes #224
|
Dear @binford2k, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the file and then makes a symlink to the original filename
when the specs are run. This will allow the module to be installed
without errors onto a windows machine.
The other alternatives I considered were things like mocking File.read to
magically translate invalid characters, but that seemed like more wtf
than this. Happy to consider other approaches though!
Fixes #224
Pull Request (PR) description
This Pull Request (PR) fixes the following issues