Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc]fix: pad dataproto when pad size is larger than len(dataproto) #150

Merged
merged 2 commits into from
Jan 28, 2025
Merged

[misc]fix: pad dataproto when pad size is larger than len(dataproto) #150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4cc474
fix pad dataproto when pad size is larger than len(dataproto)
PeterSH6 Jan 28, 2025
769d440
add test
vermouth1992 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion verl/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,13 @@ def pad_dataproto_to_divisor(data: 'DataProto', size_divisor: int):
assert isinstance(data, DataProto), 'data must be a DataProto'
vermouth1992 marked this conversation as resolved.
Show resolved Hide resolved
if len(data) % size_divisor != 0:
pad_size = size_divisor - len(data) % size_divisor
data_padded = DataProto.concat([data, data[:pad_size]])
padding_protos = []
remaining_pad = pad_size
while remaining_pad > 0:
take_size = min(remaining_pad, len(data))
padding_protos.append(data[:take_size])
remaining_pad -= take_size
data_padded = DataProto.concat([data] + padding_protos)
else:
pad_size = 0
data_padded = data
Expand Down
Loading