New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc]fix: pad dataproto when pad size is larger than len(dataproto) #150

Merged

vermouth1992 merged 2 commits into main from gm/fix_pad

Jan 28, 2025

Collaborator

PeterSH6 commented Jan 28, 2025 •

edited

Loading

As titled
Solved: Test data padding does not match world_size? #149

Waiting for testing from @chujiezheng


          fix pad dataproto when pad size is larger than len(dataproto)

d4cc474

vermouth1992 reviewed

View reviewed changes

verl/protocol.py Show resolved Hide resolved

chujiezheng commented Jan 28, 2025

This fix works for me


          add test

769d440

vermouth1992 merged commit ab525bc into main

10 checks passed

vermouth1992 deleted the gm/fix_pad branch

January 28, 2025 13:18

vermouth1992 mentioned this pull request

Test data padding does not match world_size? #149

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet