Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Tablet picker: Handle the case where a primary tablet is not setup for a shard (#17573) #17574

Merged
merged 1 commit into from
Jan 19, 2025

Tablet picker: Handle the case where a primary tablet is not setup fo…

d20be75
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Tablet picker: Handle the case where a primary tablet is not setup for a shard (#17573) #17574

Tablet picker: Handle the case where a primary tablet is not setup fo…
d20be75
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2025 in 0s

65.25% (+0.04%) compared to 9757846

View this Pull Request on Codecov

65.25% (+0.04%) compared to 9757846

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.25%. Comparing base (9757846) to head (d20be75).

Files with missing lines Patch % Lines
go/vt/topo/tablet.go 33.33% 2 Missing ⚠️
go/vt/discovery/tablet_picker.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17574      +/-   ##
================================================
+ Coverage         65.21%   65.25%   +0.04%     
================================================
  Files              1560     1560              
  Lines            238345   238351       +6     
================================================
+ Hits             155427   155527     +100     
+ Misses            82918    82824      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.