Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use VirtualFiles to save dot file, improved logging #115

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: Use VirtualFiles to save dot file, improved logging #115

merged 2 commits into from
Oct 4, 2024

Conversation

MarcinVaadin
Copy link
Member

Description

Use VirtualFile to save .copilot-plugin.properties file.

Based on contribution by @sveinnetnordic

Fixes #47

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

This was referenced Oct 2, 2024
Closed
Closed
@sveinnetnordic
Copy link

Artifact build on last commit: distributions.zip. For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

This works for me :-)

Artur-
Artur- approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Artur- Artur- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions/nits about logging

src/main/kotlin/com/vaadin/plugin/copilot/CopilotPluginUtil.kt
}
LOG.info("Project directory: $projectDir")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this info or debug info?

src/main/kotlin/com/vaadin/plugin/copilot/CopilotPluginUtil.kt
} catch (e: IOException) {
LOG.error("Failed to write to $DOTFILE: ${e.message}")
}
LOG.info("$newFile created")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this info or debug info?

Copy link
Member Author

@MarcinVaadin MarcinVaadin Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://plugins.jetbrains.com/docs/intellij/ide-infrastructure.html#logging INFO and above goes to idea.log by default. As I'm looking into other log files entries ours fits perfectly. It's information about work of plugin so I would keep it as INFO.

@MarcinVaadin MarcinVaadin merged commit 3ab168f into main Oct 4, 2024
4 checks passed
@MarcinVaadin MarcinVaadin deleted the fix/use-virtual-files-for-saving-dotfile branch October 4, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artur- Artur- Artur- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Error report] java.lang.Throwable: Cannot create .copilot-plugin
3 participants
@MarcinVaadin @sveinnetnordic @Artur-