Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better project base path detection #113

Closed
wants to merge 5 commits into from

Conversation

MarcinVaadin
Copy link
Member

@MarcinVaadin MarcinVaadin commented Oct 1, 2024

Description

Do not use project.basePath for detecting project root.

From IntelliJ java docs:

   * <p>It's <b>strongly recommended</b> to use other methods instead of this one (see {@link #getBaseDir()} for alternatives. Most
   * probably any use of this method in production code may lead to unexpected results for some projects (e.g. if {@code .idea} directory is
   * stored not near the project files).
   * </p>

Fixes #47

@MarcinVaadin MarcinVaadin marked this pull request as draft October 1, 2024 13:55
@MarcinVaadin MarcinVaadin marked this pull request as ready for review October 2, 2024 08:05
Copy link

github-actions bot commented Oct 2, 2024

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@MarcinVaadin
Copy link
Member Author

Might be not needed if user accepts #115

@MarcinVaadin MarcinVaadin deleted the fix/better-detection-of-base-path branch October 4, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error report] java.lang.Throwable: Cannot create .copilot-plugin
1 participant