Cordova 15 #420
Merged
Cordova 15 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlepinski
force-pushed
the
MOBILE-3860
branch
2 times, most recently
from
6f0e51a
to
8abfe0c
Compare
jyaganeh
requested changes
Mar 4, 2024
.github/CODEOWNERS
Outdated
| * @crow @rlepinski @khmMouna @oristanovic @Apekka @Ulrico972 @jyaganeh |
There was a problem hiding this comment.
nbd, but we could switch this to @urbanairship/mobile and not have to worry about updating it again
.gitignore
Outdated
| @@ -10,3 +10,4 @@ out/* | |||
| node_modules/* | |||
| scripts/update_cordova/node_modules/* | |||
| config_sample.xml | |||
| urbanairship-cordova/docs | |||
There was a problem hiding this comment.
did we want to add cordova-airship/docs here too (or instead)?
| @@ -1,11 +1,11 @@ | |||
| dependencies { | |||
| implementation 'com.urbanairship.android:urbanairship-accengage:16.11.1' | |||
| api "com.urbanairship.android:airship-framework-proxy:5.2.1" | |||
| } | |||
|
|
|||
| cdvPluginPostBuildExtras.push({ | |||
| android { | |||
| compileSdkVersion 33 | |||
There was a problem hiding this comment.
can we use 34, or is cordova not there yet?
crow
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cordova 15 release/rewrite.
TODO:
Going to do the following in another PR since this is getting too large: