Mobile 3860 #32
Merged
Mobile 3860 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crow
reviewed
Mar 1, 2024
| let endHour: UInt | ||
| let endMinute: UInt | ||
|
|
||
| public init(startHour: UInt, startMinute: UInt, endHour: UInt, endMinute: UInt) throws { |
There was a problem hiding this comment.
probably want to check end time is later than start time
There was a problem hiding this comment.
it actually does not need to be checked since you can have it start at 10pm and end at 6am or something
crow
reviewed
Mar 1, 2024
| @@ -32,6 +34,24 @@ public class DefaultMessageCenterUI { | |||
| ) | |||
| } | |||
|
|
|||
| @MainActor | |||
| func displayMessageView(messageID: String) { | |||
| guard let scene = try? AirshipUtils.findWindowScene() else { | |||
There was a problem hiding this comment.
lastActiveScene, findWindowScene is private now
crow
approved these changes
Mar 1, 2024
Apekka
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for urbanairship/urbanairship-cordova#420: