Fix fk name change detection in schema comparator

As index renaming support was introduced a while back do the same for foreign key name changes. Signed-off-by: Christoph Krapp <[email protected]>
uncaught · Sep 6, 2024 · 57c98da · 57c98da
1 parent 67305ee
commit 57c98da
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/Schema/Comparator.php b/src/Schema/Comparator.php
@@ -555,6 +555,10 @@ private function detectRenamedIndexes(array &$addedIndexes, array &$removedIndex
      */
     public function diffForeignKey(ForeignKeyConstraint $key1, ForeignKeyConstraint $key2)
     {
+        if (strtolower($key1->getName()) !== strtolower($key2->getName())) {
+            return true;
+        }
+
         if (
             array_map('strtolower', $key1->getUnquotedLocalColumns())
             !== array_map('strtolower', $key2->getUnquotedLocalColumns())

diff --git a/tests/Schema/AbstractComparatorTestCase.php b/tests/Schema/AbstractComparatorTestCase.php
@@ -682,9 +682,17 @@ public function testDetectForeignKeyNameChange(): void
         $tableB->addColumn('ID', Types::INTEGER);
         $tableB->addForeignKeyConstraint('bar', ['id'], ['id'], [], 'bar_constraint');
 
-        $tableDiff = $this->comparator->diffTable($tableA, $tableB);
-
-        self::assertFalse($tableDiff);
+        $fkA = new ForeignKeyConstraint(['id'], 'bar', ['id'], 'foo_constraint');
+        $fkA->setLocalTable($tableA);
+        $fkB = new ForeignKeyConstraint(['id'], 'bar', ['id'], 'bar_constraint');
+        $fkB->setLocalTable($tableB);
+        $tableDiff = new TableDiff(
+            tableName: 'foo',
+            fromTable: $tableA,
+            addedForeignKeys: [$fkB],
+            removedForeignKeys: [$fkA],
+        );
+        self::assertEquals($tableDiff, $this->comparator->compareTables($tableA, $tableB));
     }
 
     public function testCompareForeignKeyRestrictNoActionAreTheSame(): void