Skip to content

Commit

Permalink
Fix test names to reflect their actual purpose
Browse files Browse the repository at this point in the history
Both tests did expect a name change to result in an empty table diff in
the past. When index renaming support was introduced the name of the
test was not changed to reflect the new expectation.

Signed-off-by: Christoph Krapp <[email protected]>
  • Loading branch information
achterin authored and uncaught committed Sep 6, 2024
1 parent d7dc08f commit 67305ee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/Schema/AbstractComparatorTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ public function testCompareColumnCompareCaseInsensitive(): void
self::assertFalse($tableDiff);
}

public function testCompareIndexBasedOnPropertiesNotName(): void
public function testDetectIndexNameChange(): void
{
$tableA = new Table('foo');
$tableA->addColumn('id', Types::INTEGER);
Expand All @@ -672,7 +672,7 @@ public function testCompareIndexBasedOnPropertiesNotName(): void
);
}

public function testCompareForeignKeyBasedOnPropertiesNotName(): void
public function testDetectForeignKeyNameChange(): void
{
$tableA = new Table('foo');
$tableA->addColumn('id', Types::INTEGER);
Expand Down

0 comments on commit 67305ee

Please sign in to comment.