Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass S3 Client to smart_open to prevent it from creating own client #178

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Pass S3 Client to smart_open to prevent it from creating own client #178

merged 4 commits into from
Jul 12, 2024

Commits on Jul 10, 2024

  1. Pass S3 Client to smart_open to prevent it from creating own client 

    The package smart_open would create an S3 Client and expected to find
the environment keys `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY`
however these were renamed and appended with `DEFAULT_` which caused
a credentials error. Now smart_open is given the S3 Client and longer
has to create the S3 Client which now works as expected.
    @DeanElliott96
    DeanElliott96 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    22540e6 View commit details
    Browse the repository at this point in the history

  2. Update tests for new S3Client parameter

    @DeanElliott96
    DeanElliott96 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ba55137 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Update tests for replacement of mgmt command with task

    @DeanElliott96
    DeanElliott96 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7d341e1 View commit details
    Browse the repository at this point in the history

  2. Remove unused imports

    @DeanElliott96
    DeanElliott96 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    98744fb View commit details
    Browse the repository at this point in the history