Pass S3 Client to smart_open to prevent it from creating own client #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package smart_open would create an S3 Client and expected to find the environment keys `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY` however these were renamed and appended with `DEFAULT_` which caused a credentials error. Now smart_open is given the S3 Client and longer has to create the S3 Client which now works as expected.
DeanElliott96
requested review from
cgsunkel,
marijnkampf,
p3dr0migue1 and
bau123
as code owners
p3dr0migue1
approved these changes
Jul 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## migration-deploy #178 +/- ##
====================================================
+ Coverage 37.48% 37.63% +0.14%
====================================================
Files 97 96 -1
Lines 5842 5777 -65
Branches 222 212 -10
====================================================
- Hits 2190 2174 -16
+ Misses 3581 3532 -49
Partials 71 71 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package smart_open would create an S3 Client and expected to find the environment keys
AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYhowever these were renamed and appended withDEFAULT_which caused a credentials error. Now smart_open is given the S3 Client and longer has to create the S3 Client which now works as expected.