Resolve based on open files #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoah1
force-pushed
the
auto-discover-test-cases
branch
from
d3e838c
to
8561f8c
Compare
mnoah1
added a commit
that referenced
this pull request
Oct 30, 2024
This change adds additional guidance when users have synced their test cases, but have then navigated to a file that is outside of their Bazel sync scope. Instead of a lack of test run arrows with no clear reason why, they will now see a greyed out run arrow with further information. - Open a file that's outside of the current scope. - Logic from #24 attempts to expand this file's target and add its test cases to the test explorer. - With this PR, if the step above fails, decorators will now be added in the gutter to help provide further guidance, at the locations where the run arrows would normally appear. -  - Adjust Project Scope will open the .bazelproject file for editing, and sync now triggers the test explorer's existing sync functionality. - This functionality is behind the `bazelbsp.autoExpandTarget` setting as it is part of that logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to discover targets based on a user's open files, allowing test cases in a file to be resolved even if the user hasn't specifically expanded the target in the Test Explorer tree.
During the sync process, we will now check a user's open files. If any are determined to be test files, we request the file's target from the BSP server, then resolve the test cases in that target. After this is complete, the user will be able to run tests in those files via run arrows, without first having to navigate to the test explorer tree. This is opt out via settings, as it does result in additional back and forth with the BSP server.
As a follow-up, I plan to add an inlay hint or other info to help the user update their scope if we try to find the target.