Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints to update sync scope when a test file is out of scope #26

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Oct 24, 2024

This change adds additional guidance when users have synced their test cases, but have then navigated to a file that is outside of their Bazel sync scope. Instead of a lack of test run arrows with no clear reason why, they will now see a greyed out run arrow with further information.

  • Open a file that's outside of the current scope.
  • Logic from Resolve based on open files #24 attempts to expand this file's target and add its test cases to the test explorer.
  • With this PR, if the step above fails, decorators will now be added in the gutter to help provide further guidance, at the locations where the run arrows would normally appear.
    • image
  • Adjust Project Scope will open the .bazelproject file for editing, and sync now triggers the test explorer's existing sync functionality.
  • This functionality is behind the bazelbsp.autoExpandTarget setting as it is part of that logic.

@mnoah1 mnoah1 marked this pull request as ready for review October 24, 2024 14:52
@mnoah1 mnoah1 merged commit ab3d648 into uber:main Oct 30, 2024
4 checks passed
@mnoah1 mnoah1 deleted the sync-scope-current branch October 30, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants