Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the ASTBuilder to get rid of the currentAttr attribute. #585

Merged
merged 21 commits into from
Sep 22, 2024

Fix the logic flaw!

52f6a15
Select commit
Loading
Failed to load commit list.
Merged

Refactor the ASTBuilder to get rid of the currentAttr attribute. #585

Fix the logic flaw!
52f6a15
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 20, 2024 in 1s

92.03% (-0.04%) compared to 0d07110

View this Pull Request on Codecov

92.03% (-0.04%) compared to 0d07110

Details

Codecov Report

Attention: Patch coverage is 87.87879% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.03%. Comparing base (0d07110) to head (52f6a15).

Files with missing lines Patch % Lines
pydoctor/astbuilder.py 92.95% 4 Missing and 1 partial ⚠️
pydoctor/astutils.py 77.27% 3 Missing and 2 partials ⚠️
pydoctor/extensions/zopeinterface.py 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
- Coverage   92.07%   92.03%   -0.04%     
==========================================
  Files          47       47              
  Lines        8412     8465      +53     
  Branches     1856     1868      +12     
==========================================
+ Hits         7745     7791      +46     
- Misses        391      395       +4     
- Partials      276      279       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov