Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the ASTBuilder to get rid of the currentAttr attribute. #585

Merged
merged 21 commits into from
Sep 22, 2024

Commits on May 20, 2022

  1. Refactor the ASTBuilder to get rif of the currentAttr attribute.

    This attribute was used to attach the right docstring node to the right Attribute object. Now it uses AST node navigation (with the .parent attribute) instead for fetching the docstring node for an ast.Assign.
    
    This change might not be worth it, on the one hand it removes a attribute beeing mutated at different palces in the code, but replaces this kind of "unsafe" state tracking (meaning not with pop() and push()) by some more verbose solution that involves adding the .parent attribute on all nodes.
    
    The zopeinferface extension needed to be adjusted as well because it relied on the docstring assigment feature in an implicit way, now it's explicit what we're doing.
    tristanlatr committed May 20, 2022
    Configuration menu
    Copy the full SHA
    86ba1e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31b47b1 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Configuration menu
    Copy the full SHA
    f34040d View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Configuration menu
    Copy the full SHA
    3b00c3e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    8e4390e View commit details
    Browse the repository at this point in the history
  2. cleanup

    tristanlatr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c288a96 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f366f07 View commit details
    Browse the repository at this point in the history
  4. Use a control flow exception in order to control whether to look for …

    …docstring assignments or irgnore it.
    tristanlatr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c44b3c8 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'experimental-refactor-astbuilder' of github.com:twisted…

    …/pydoctor into experimental-refactor-astbuilder
    tristanlatr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9081331 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    daf7f63 View commit details
    Browse the repository at this point in the history
  7. add few tests

    tristanlatr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e7d7826 View commit details
    Browse the repository at this point in the history
  8. Fix typing.

    tristanlatr committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    674ce69 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    a38c793 View commit details
    Browse the repository at this point in the history
  2. Fix the test case

    tristanlatr committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b9e7ed2 View commit details
    Browse the repository at this point in the history
  3. fix typing

    tristanlatr committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    54cdd9b View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Configuration menu
    Copy the full SHA
    8c60beb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53c4e70 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a0baec View commit details
    Browse the repository at this point in the history
  4. Remove comment

    tristanlatr authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    4613459 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Add a TODO comment

    tristanlatr committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c9c2ee7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix the logic flaw!

    tristanlatr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    52f6a15 View commit details
    Browse the repository at this point in the history