-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the ASTBuilder to get rid of the currentAttr attribute. #585
Merged
Commits on May 20, 2022
-
Refactor the ASTBuilder to get rif of the currentAttr attribute.
This attribute was used to attach the right docstring node to the right Attribute object. Now it uses AST node navigation (with the .parent attribute) instead for fetching the docstring node for an ast.Assign. This change might not be worth it, on the one hand it removes a attribute beeing mutated at different palces in the code, but replaces this kind of "unsafe" state tracking (meaning not with pop() and push()) by some more verbose solution that involves adding the .parent attribute on all nodes. The zopeinferface extension needed to be adjusted as well because it relied on the docstring assigment feature in an implicit way, now it's explicit what we're doing.
Configuration menu - View commit details
-
Copy full SHA for 86ba1e7 - Browse repository at this point
Copy the full SHA 86ba1e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31b47b1 - Browse repository at this point
Copy the full SHA 31b47b1View commit details
Commits on May 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f34040d - Browse repository at this point
Copy the full SHA f34040dView commit details
Commits on May 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3b00c3e - Browse repository at this point
Copy the full SHA 3b00c3eView commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8e4390e - Browse repository at this point
Copy the full SHA 8e4390eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c288a96 - Browse repository at this point
Copy the full SHA c288a96View commit details -
Configuration menu - View commit details
-
Copy full SHA for f366f07 - Browse repository at this point
Copy the full SHA f366f07View commit details -
Use a control flow exception in order to control whether to look for …
…docstring assignments or irgnore it.
Configuration menu - View commit details
-
Copy full SHA for c44b3c8 - Browse repository at this point
Copy the full SHA c44b3c8View commit details -
Merge branch 'experimental-refactor-astbuilder' of github.com:twisted…
…/pydoctor into experimental-refactor-astbuilder
Configuration menu - View commit details
-
Copy full SHA for 9081331 - Browse repository at this point
Copy the full SHA 9081331View commit details -
Configuration menu - View commit details
-
Copy full SHA for daf7f63 - Browse repository at this point
Copy the full SHA daf7f63View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d7826 - Browse repository at this point
Copy the full SHA e7d7826View commit details -
Configuration menu - View commit details
-
Copy full SHA for 674ce69 - Browse repository at this point
Copy the full SHA 674ce69View commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a38c793 - Browse repository at this point
Copy the full SHA a38c793View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9e7ed2 - Browse repository at this point
Copy the full SHA b9e7ed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54cdd9b - Browse repository at this point
Copy the full SHA 54cdd9bView commit details
Commits on Sep 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8c60beb - Browse repository at this point
Copy the full SHA 8c60bebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c4e70 - Browse repository at this point
Copy the full SHA 53c4e70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a0baec - Browse repository at this point
Copy the full SHA 5a0baecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4613459 - Browse repository at this point
Copy the full SHA 4613459View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c9c2ee7 - Browse repository at this point
Copy the full SHA c9c2ee7View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 52f6a15 - Browse repository at this point
Copy the full SHA 52f6a15View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.