Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-128961 / 24.10 / Improve CDROM device validation #13704

Merged
merged 1 commit into from
May 17, 2024
Merged

NAS-128961 / 24.10 / Improve CDROM device validation #13704

merged 1 commit into from
May 17, 2024

Conversation

Qubad786
Copy link
Contributor

Context

Changes have been added to enhance validation for CDROM devices and avoid adding path which are not a file or are not under /mnt.

@Qubad786 Qubad786 added the jira label May 13, 2024
@Qubad786 Qubad786 requested a review from a team May 13, 2024 14:44
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128961

@bugclerk bugclerk changed the title Improve CDROM device validation NAS-128961 / 24.10 / Improve CDROM device validation May 13, 2024
anodos325
anodos325 requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@anodos325 anodos325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use standard path validator for middleware unless there is specific reason not to.

@Qubad786 Qubad786 force-pushed the mrehan/enhance-cdrom-device-validation branch from 0c80379 to 049c6d4 Compare May 14, 2024 12:15
@Qubad786 Qubad786 requested a review from anodos325 May 14, 2024 12:15
anodos325
anodos325 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@anodos325 anodos325 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to our async path validator. You can at least duplicate some of checks there..

@Qubad786 Qubad786 force-pushed the mrehan/enhance-cdrom-device-validation branch from 049c6d4 to 8af36bb Compare May 14, 2024 22:12
@Qubad786 Qubad786 requested a review from anodos325 May 14, 2024 22:12
@anodos325
Copy link
Contributor

anodos325 commented May 16, 2024 •
edited
Loading

https://github.com/truenas/middleware/pull/13741/files
I added a sync version of path validator. Let's use that instead.

@truenas truenas deleted a comment from bugclerk May 16, 2024
@Qubad786 Qubad786 force-pushed the mrehan/enhance-cdrom-device-validation branch from 8af36bb to 047662f Compare May 16, 2024 18:46
@Qubad786 Qubad786 requested review from anodos325 and removed request for anodos325 May 16, 2024 18:46
@Qubad786 Qubad786 requested a review from anodos325 May 17, 2024 10:40
@Qubad786 Qubad786 force-pushed the mrehan/enhance-cdrom-device-validation branch from 047662f to cef5275 Compare May 17, 2024 10:40
@Qubad786 Qubad786 merged commit b0c65eb into master May 17, 2024
3 checks passed
@Qubad786 Qubad786 deleted the mrehan/enhance-cdrom-device-validation branch May 17, 2024 13:40
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anodos325 anodos325 anodos325 approved these changes

Assignees
No one assigned
Labels
jira no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qubad786 @bugclerk @anodos325